Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[CP] Roll Skia to 93461bed7394e3c554125b0c50b00fb81eea42c6#56545

Merged
auto-submit[bot] merged 2 commits intoflutter:flutter-3.24-candidate.0from
cbracken:flutter-3.24-candidate.0
Nov 13, 2024
Merged

[CP] Roll Skia to 93461bed7394e3c554125b0c50b00fb81eea42c6#56545
auto-submit[bot] merged 2 commits intoflutter:flutter-3.24-candidate.0from
cbracken:flutter-3.24-candidate.0

Conversation

@cbracken
Copy link
Member

This picks up https://skia-review.googlesource.com/c/skia/+/919136 which fixes an iOS App Store rejection issue.

Issue: flutter/flutter#158423

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

'skia_git': 'https://skia.googlesource.com',
'llvm_git': 'https://llvm.googlesource.com',
'skia_revision': '9d530bb0bcbfd571ee3d820fdd79ff859d61e2cd',
'skia_revision': '93461bed7394e3c554125b0c50b00fb81eea42c6',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 12, 2024
@auto-submit auto-submit bot merged commit a18df97 into flutter:flutter-3.24-candidate.0 Nov 13, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 13, 2024
@cbracken cbracken deleted the flutter-3.24-candidate.0 branch November 13, 2024 01:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants