This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[cp:stable][web] Work around wrong pointerId in coalesced events in iOS Safari 18.2 (#56719)#56903
Merged
auto-submit[bot] merged 1 commit intoflutter:flutter-3.24-candidate.0from Jan 9, 2025
Conversation
…ri 18.2 (flutter#56719) In iOS 18.2, Safari [added support](https://developer.apple.com/documentation/safari-release-notes/safari-18_2-release-notes#Web-API) for the [`getCoalescedEvents`](https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/getCoalescedEvents) API. That being said, the API seems to be incomplete (or at least doesn't match other browsers' behavior). The coalesced events lack a [`pointerId`](https://developer.mozilla.org/en-US/docs/Web/API/PointerEvent/pointerId) and [`target`](https://developer.mozilla.org/en-US/docs/Web/API/Event/target) properties. I'm not sure if this issue will be fixed in the stable release of iOS 18.2, so in the meantime, this PR implements a workaround to avoid this issue. Fixes flutter/flutter#158299 Fixes flutter/flutter#155987
ditman
approved these changes
Dec 2, 2024
Member
ditman
left a comment
There was a problem hiding this comment.
LGTM! Thanks for cherry-picking this fix!
|
Allow me share that we have tens of users running into this issue. Thank you implementing a workaround! We look forward to seeing this change in 3.24.6! |
Couldn't agree more! We have a lot of iOS users and 18.2 may be out as early as next week! |
7 tasks
fe55d9b
into
flutter:flutter-3.24-candidate.0
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual cherry pick for #56719
Cherrypick request: flutter/flutter#159691