Skip to content

Remove globals_null_migrated.dart, move into globals.dart#92948

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
jmagman:globals-null
Nov 3, 2021
Merged

Remove globals_null_migrated.dart, move into globals.dart#92948
fluttergithubbot merged 1 commit intoflutter:masterfrom
jmagman:globals-null

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 3, 2021

Not sure how this happened, but I lost a few imports and actually deleting globals_null_migrated.dart in #92861

Part of #71511

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@jmagman jmagman added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 3, 2021
@jmagman jmagman self-assigned this Nov 3, 2021
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@jmagman
Copy link
Member Author

jmagman commented Nov 3, 2021

Google testing is mad that #92861 hasn't yet rolled.

@fluttergithubbot fluttergithubbot merged commit 868e417 into flutter:master Nov 3, 2021
@jmagman jmagman deleted the globals-null branch November 3, 2021 20:26
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
@jmagman jmagman added the a: null-safety Support for Dart's null safety feature label Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: null-safety Support for Dart's null safety feature tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants