Skip to content

Remove shade50 getter from MaterialAccentColor#93507

Merged
fluttergithubbot merged 1 commit intoflutter:masterfrom
Reekoooo:fix93270
Nov 16, 2021
Merged

Remove shade50 getter from MaterialAccentColor#93507
fluttergithubbot merged 1 commit intoflutter:masterfrom
Reekoooo:fix93270

Conversation

@Reekoooo
Copy link
Contributor

@Reekoooo Reekoooo commented Nov 11, 2021

This PR removes shade50 getter from MaterialAccentColor class. It is not part of Material design 2014 specs and calling it causes null pointer exception at runtime.

List which issues are fixed by this PR. You must list at least one issue.
Fix #93270

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Nov 11, 2021
@google-cla google-cla bot added the cla: yes label Nov 11, 2021
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 3f8e77e into flutter:master Nov 16, 2021
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
@Reekoooo Reekoooo deleted the fix93270 branch November 19, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

failed non-null assertion on MaterialAccentColor.shade50

3 participants