linkerd: update prometheus URL based on the latest 2.10 changes #845
Conversation
In Linkerd 2.10, The Prometheus instance moved into the `viz` extension which is installed separately from the core control-plane. This means that the prometheus now exists in the `linkerd-viz` namespace by default unless overriden. This PR updates the URl to reflect the same Signed-off-by: Tarun Pothulapati <[email protected]>
|
@Pothulapati does this means the tutorial here will no longer work? https://docs.flagger.app/tutorials/linkerd-progressive-delivery I guess we need to specify the commands to install Linkerd and Prometheus in there |
|
Can you please update the e2e tests also https://github.com/fluxcd/flagger/tree/main/test/linkerd |
Signed-off-by: Tarun Pothulapati <[email protected]>
Signed-off-by: Tarun Pothulapati <[email protected]>
|
@Pothulapati can you please rebase with main, I've fixed the failing e2e test. |
|
Thanks, now it fails like I've expected it: |
|
@stefanprodan Yep. Should I make this PR wait for the next stable release i.e |
|
@Pothulapati thanks for this, can you please squash the commits? |
This commit updates the linkerd version to `2.10`, along with the install script to download the arm version. It also updates the install script and metricsTempalte to install and use the viz Prometheus respectively. Signed-off-by: Tarun Pothulapati <[email protected]>
c29e3d2
to
4a66a28
Compare
In Linkerd 2.10, The Prometheus instance moved into the
vizextension which is installed separately from the core
control-plane. This means that the prometheus now exists in
the
linkerd-viznamespace by default unless overriden.This PR updates the URl to reflect the same
Signed-off-by: Tarun Pothulapati [email protected]