Skip to content

Fix build with BUILD_SHARED_LIBS=ON#132

Merged
foonathan merged 5 commits intofoonathan:mainfrom
MiguelCompany:feature/dll-aware
Mar 30, 2022
Merged

Fix build with BUILD_SHARED_LIBS=ON#132
foonathan merged 5 commits intofoonathan:mainfrom
MiguelCompany:feature/dll-aware

Conversation

@MiguelCompany
Copy link
Copy Markdown
Contributor

@MiguelCompany MiguelCompany commented Mar 29, 2022

This should fix #131 by deprecating virtual_memory_page_size and adding function get_virtual_memory_page_size().

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany MiguelCompany marked this pull request as draft March 29, 2022 13:21
@MiguelCompany MiguelCompany marked this pull request as ready for review March 29, 2022 14:56
@foonathan
Copy link
Copy Markdown
Owner

Hm, this is a breaking change. Maybe it's better to call the function get_virtual_memory_page_size() and have a (deprecated) static const std::size_t virtual_memory_page_size = get_virtual_memory_page_size()? That being said, it probably doesn't matter. I leave the decision up to you.

Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@MiguelCompany
Copy link
Copy Markdown
Contributor Author

I do prefer non-breaking changes, so I just added the getter function that returns the constant.

@foonathan foonathan merged commit 5e523a9 into foonathan:main Mar 30, 2022
@foonathan
Copy link
Copy Markdown
Owner

Thank you!

@MiguelCompany MiguelCompany deleted the feature/dll-aware branch March 30, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building tests on Windows fails with BUILD_SHARED_LIBS=ON

2 participants