Style default buttons as links #497
Conversation
| overflow: visible; | ||
| padding: 0; | ||
| text-align: left; | ||
| text-decoration: underline; |
There was a problem hiding this comment.
I added a text-button mixin that you can use here to make buttons look like regular text links: https://github.com/forumone/gesso_next/blob/main/source/00-config/mixins/_button.scss#L101-L119
There was a problem hiding this comment.
Thanks! I switched to using that mixin to account for a bunch of the default button styles.
* 5.x: (198 commits) version bump updated with Dan's suggestions Optimize F1 logo Update README to match coding standards replaced missing f1 logo with local copy fixed generated image directory path and updated some documentation Remove whitespace around buttons Update button spacing styles fix title_display var name added front class to homepage in storybook Check if menubarItem has a popupMenu before closing Close all open dropdown menus before opening new one Fix required form item labels in Drupal Fix indentation in form item template version bump updated some packages Update Gesso for node 16 version bump version bump added Prettier formatting ...
|
This PR is from 2021 (!!). Reviewing the issue, seems like @dcmouyard , you validated this approach on NRDC and confirmed the buttons it applied to made more sense styled as links rather than matching |
|
I still haven’t run into any problems with this approach, and I would use it again on all of my future projects. |
This PR closes #488.
This work could potentially affect button styling from Drupal core and contrib styles, so I think this needs thorough QA before it gets merged in. I’m going to try this approach on NRDC if we want to use that project as a guinea pig.