fix: show contextual toast when saving with no targets#2748
Merged
oschwartz10612 merged 1 commit intofosrl:mainfrom Mar 31, 2026
Merged
Conversation
Instead of always showing "Settings updated" when saving, show "Targets cleared" when the target list is empty. This gives the user accurate feedback without blocking the save action. Fixes fosrl#586
Member
|
This is good thanks! |
oschwartz10612
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2711 based on maintainer feedback — saving with no targets should still work (to allow clearing targets), but the notification should reflect what actually happened.
What changed: Instead of always showing "Settings updated" when saving, the toast now shows:
No save action is blocked — this only changes the notification text.
Fixes #586
Test plan