perf: GLE reposting with progress and chunking#31343
Merged
ankush merged 1 commit intofrappe:developfrom Jun 14, 2022
Merged
Conversation
cc15826 to
c19d3ed
Compare
Codecov Report
@@ Coverage Diff @@
## develop #31343 +/- ##
===========================================
+ Coverage 63.57% 63.64% +0.07%
===========================================
Files 984 984
Lines 67530 67539 +9
===========================================
+ Hits 42931 42985 +54
+ Misses 24599 24554 -45
|
b2c0b9c to
c1e2fb5
Compare
If stock voucher count goes >1000 then fetching all gles and reposting them all at once requires much more memory and can cause crash. - This PR ensures that GLE reposting is done in chunks of 100 vouchers. - This PR also starts keeping track of how many such chunks were processed so in future progress is resumed in event of timeout.
c1e2fb5 to
817c615
Compare
Closed
mergify bot
pushed a commit
that referenced
this pull request
Jun 14, 2022
If stock voucher count goes >1000 then fetching all gles and reposting them all at once requires much more memory and can cause crash. - This PR ensures that GLE reposting is done in chunks of 100 vouchers. - This PR also starts keeping track of how many such chunks were processed so in future progress is resumed in event of timeout. (cherry picked from commit 2535d5e) # Conflicts: # erpnext/accounts/utils.py
This was referenced Jun 15, 2022
ankush
added a commit
that referenced
this pull request
Jun 15, 2022
) * fix: dont use cached doc for GLE reposts ported from #31240 * perf: GLE reposting with progress and chunking If stock voucher count goes >1000 then fetching all gles and reposting them all at once requires much more memory and can cause crash. - This PR ensures that GLE reposting is done in chunks of 100 vouchers. - This PR also starts keeping track of how many such chunks were processed so in future progress is resumed in event of timeout. * test: add "actual" test for chunked GLE reposting
frappe-pr-bot
pushed a commit
that referenced
this pull request
Jun 21, 2022
## [13.34.1](v13.34.0...v13.34.1) (2022-06-21) ### Bug Fixes * Conversion rate validation for multi-currency invoices ([4186aaf](4186aaf)) * **india:** e-invoice eligibility if company gstin is not configured ([#31247](#31247)) ([7696ae4](7696ae4)) * internal transfer GLE validation ([8a4cd2a](8a4cd2a)) * Merge Conflicts ([0f3a02d](0f3a02d)) * Pick Template BOM if variant BOM absent in WO popup from SO ([7c35887](7c35887)) * Quotation lost update ([3b9f943](3b9f943)) * Spelling mistake in quotation depend on (backport [#31362](#31362)) ([#31363](#31363)) ([ebcdaf7](ebcdaf7)) * transaction date gets unset in material request ([#31387](#31387)) ([4e2ed6f](4e2ed6f)), closes [#31327](#31327) * UOM handling for transaction without item (backport [#31389](#31389)) ([#31391](#31391)) ([051e5cd](051e5cd)) ### Performance Improvements * GLE reposting with progress and chunking (backport [#31343](#31343)) ([#31373](#31373)) ([f19ed0b](f19ed0b))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If stock voucher count goes >1000 then fetching all gles and reposting
them all at once requires much more memory and can cause crash.
processed so in future progress is resumed in event of timeout. Similar to fix: added progress bar in repost item valuation to check the status #26630 but for GLE.