Only accept iterables, not any array-likes

fregante · Jun 23, 2022 · ec3232d · ec3232d
1 parent 6ac66e2
commit ec3232d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/index.ts b/index.ts
@@ -54,7 +54,7 @@ function editLedger(
 }
 
 function isEventTarget(
-	elements: EventTarget | Document | ArrayLike<Element> | string,
+	elements: EventTarget | Document | Iterable<Element> | string,
 ): elements is EventTarget {
 	return typeof (elements as EventTarget).addEventListener === 'function';
 }
@@ -83,7 +83,7 @@ function delegate<
 	TElement extends Element = ParseSelector<Selector, HTMLElement>,
 	TEventType extends EventType = EventType,
 >(
-	base: EventTarget | Document | ArrayLike<Element> | string,
+	base: EventTarget | Document | Iterable<Element> | string,
 	selector: Selector,
 	type: TEventType,
 	callback: DelegateEventHandler<GlobalEventHandlersEventMap[TEventType], TElement>,
@@ -94,7 +94,7 @@ function delegate<
 	TElement extends Element = HTMLElement,
 	TEventType extends EventType = EventType,
 >(
-	base: EventTarget | Document | ArrayLike<Element> | string,
+	base: EventTarget | Document | Iterable<Element> | string,
 	selector: string,
 	type: TEventType,
 	callback: DelegateEventHandler<GlobalEventHandlersEventMap[TEventType], TElement>,
@@ -106,7 +106,7 @@ function delegate<
 	TElement extends Element,
 	TEventType extends EventType = EventType,
 >(
-	base: EventTarget | Document | ArrayLike<Element> | string,
+	base: EventTarget | Document | Iterable<Element> | string,
 	selector: string,
 	type: TEventType,
 	callback: DelegateEventHandler<GlobalEventHandlersEventMap[TEventType], TElement>,
@@ -137,9 +137,9 @@ function delegate<
 
 	// Handle Array-like based usage
 	if (!isEventTarget(base)) {
-		Array.prototype.forEach.call(base, element => {
+		for (const element of base) {
 			delegate(element, selector, type, callback, listenerOptions);
-		});
+		}
 
 		return internalController;
 	}

diff --git a/package.json b/package.json
@@ -39,7 +39,6 @@
 		],
 		"rules": {
 			"max-params": "off",
-			"@typescript-eslint/no-namespace": "off",
 			"@typescript-eslint/naming-convention": "off"
 		}
 	},