Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TSDoc for options parameter #27

Merged
merged 1 commit into from
Oct 9, 2021
Merged

Conversation

busches
Copy link
Contributor

@busches busches commented Oct 9, 2021

When consuming this in RGH, I had to look up what the boolean argument of the options parameter did, submitting this to help anyone else in the future.

Wasn't sure if you want this or if you do, if you want them all filled in, I felt the others were more self explanatory.

@fregante fregante marked this pull request as ready for review October 9, 2021 18:08
@fregante
Copy link
Owner

fregante commented Oct 9, 2021

@fregante fregante marked this pull request as ready for review 2 minutes ago

oops, my bad 😃

@fregante fregante changed the title Add TSDoc for options argument Add TSDoc for options parameter Oct 9, 2021
@fregante fregante merged commit ec81f44 into fregante:main Oct 9, 2021
@fregante
Copy link
Owner

fregante commented Oct 9, 2021

Thank you!

@busches busches deleted the patch-1 branch October 12, 2021 02:00
@busches
Copy link
Contributor Author

busches commented Oct 12, 2021

Happy to help, if it's only my future self. Can you tag this with hacktoberfest-accepted so I can get a tree planted? :D

@fregante
Copy link
Owner

Someone on RG’s repo mentioned the PR just needs to be accepted or merged to be counted. Can you confirm?

@busches
Copy link
Contributor Author

busches commented Oct 12, 2021

Someone on RG’s repo mentioned the PR just needs to be accepted or merged to be counted. Can you confirm?

Yes and has to be in a participating repo, which can be done via this label or a repo wide one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants