fix unclosed attribute selector

g-plane · Aug 12, 2024 · 5d69d0c · 5d69d0c
1 parent ccda793
commit 5d69d0c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- Fixed parsing unclosed attribute selector (such as `a[href`).
+
 ## v2.11.3
 
 - Fixed for TypeScript 5.5.

diff --git a/parser.d.ts b/parser.d.ts
@@ -68,6 +68,8 @@ type PreprocessUnchecked<I> = I extends `${infer L}\\${Quotes}${infer R}` // rem
   ? PreprocessUnchecked<`${L}${R}`>
   : I extends `${infer L}[${string}]${infer R}` // process attribute
   ? PreprocessUnchecked<`${L}#x${R}`> // replace it with a fake ID selector
+  : I extends `${infer L}[${string}${infer R}` // process unclosed attribute
+  ? PreprocessUnchecked<`${L}#x${R}`> // replace it with a fake ID selector
   : I
 
 /** Parse `:is()` and `:where()` */

diff --git a/parser.test.ts b/parser.test.ts
@@ -78,6 +78,7 @@ type _Tests = [
   Expect<Equal<ParseSelector<'div[data-key*=value]'>, HTMLDivElement>>,
   Expect<Equal<ParseSelector<'div[data-key="value"i]'>, HTMLDivElement>>,
   Expect<Equal<ParseSelector<'div[data-key="value"s]'>, HTMLDivElement>>,
+  Expect<Equal<ParseSelector<'div[data-key'>, HTMLDivElement>>,
   Expect<Equal<ParseSelector<'div[]'>, Element>>,
   Expect<
     Equal<ParseSelector<'link[type="application/atom+xml"]'>, HTMLLinkElement>