fix: add missing type guards

gajus · Dec 17, 2024 · 21f9595 · 21f9595
1 parent efb1f03
commit 21f9595
Show file tree

Hide file tree

Showing 6 changed files with 23 additions and 4 deletions.
diff --git a/src/rules/idMatch.ts b/src/rules/idMatch.ts
@@ -269,6 +269,7 @@ export default createRule<Options, MessageIds>({
             // Ignore named import
           } else if (
             'local' in parent &&
+            parent.local.type === AST_NODE_TYPES.Identifier &&
             parent.local.name === node.name &&
             isInvalid(name)
           ) {

diff --git a/src/rules/noReExport.ts b/src/rules/noReExport.ts
@@ -87,13 +87,20 @@ export default createRule<Options, MessageIds>({
           }
         } else if (node.specifiers) {
           for (const specifier of node.specifiers) {
-            if (node.source && specifier.local.name === 'default') {
+            if (
+              node.source &&
+              specifier.exported.type === AST_NODE_TYPES.Identifier &&
+              specifier.local.type === AST_NODE_TYPES.Identifier &&
+              specifier.local.name === 'default'
+            ) {
               // export { default as Button } from 'app/CustomButtom';
               appendToExports(specifier.exported.name, {
                 location: specifier.exported.loc,
                 type: 'DefaultReExport',
               });
-            } else {
+            } else if (
+              specifier.local.type === AST_NODE_TYPES.Identifier
+            ) {
               // export { Button }
               appendToExports(specifier.local.name, {
                 location: specifier.local.loc,

diff --git a/src/rules/noReassignImports.ts b/src/rules/noReassignImports.ts
@@ -1,3 +1,4 @@
+import { AST_NODE_TYPES } from '@typescript-eslint/types';
 import { createRule } from '../utilities';
 
 type Options = [];
@@ -77,7 +78,11 @@ export default createRule<Options, keyof typeof messages>({
       },
       ImportDeclaration(node) {
         for (const specifier of node.specifiers) {
-          if (specifier.type !== 'ImportSpecifier') {
+          if (specifier.type !== AST_NODE_TYPES.ImportSpecifier) {
+            continue;
+          }
+
+          if (specifier.imported.type !== AST_NODE_TYPES.Identifier) {
             continue;
           }
 

diff --git a/src/rules/noRestrictedImports.ts b/src/rules/noRestrictedImports.ts
@@ -92,7 +92,8 @@ export default createRule<Options, keyof typeof messages>({
 
         const importSpecifiers = node.specifiers.filter(
           (specifier) =>
-            specifier.type === 'ImportSpecifier' &&
+            specifier.type === AST_NODE_TYPES.ImportSpecifier &&
+            specifier.imported.type === AST_NODE_TYPES.Identifier &&
             specifier.imported.name === importName,
         );
 

diff --git a/src/rules/preferReactLazy.ts b/src/rules/preferReactLazy.ts
@@ -30,6 +30,10 @@ export default createRule<Options, MessageIds>({
             continue;
           }
 
+          if (specifier.imported.type !== 'Identifier') {
+            continue;
+          }
+
           imported.push(specifier.imported.name);
         }
       },

diff --git a/src/rules/requireExtension.ts b/src/rules/requireExtension.ts
@@ -218,6 +218,7 @@ const handleAliasPath = (
   }
 
   if (!resolvedImportPath) {
+    // @ts-expect-error TODO check what's going on here
     resolvedImportPath = resolveImport(importPath, context);
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -218,6 +218,7 @@ const handleAliasPath = ( @@
       }
       if (!resolvedImportPath) {
+        // @ts-expect-error TODO check what's going on here
         resolvedImportPath = resolveImport(importPath, context);
       }
@@ Expand Down @@