Skip to content

Conversation

@androidnisse
Copy link
Contributor

Summary

  • C extension now enables multi-phase module initialization (PEP 489). For CPython >= 3.11, the hookable type is now a heap-allocated type.
  • Drop support for Python 3.7.
  • Add support for Python 3.13.

Test Plan

  • Checked it build correctly.

Checklist

  • Package was built and tested against unstable

Packaging notes

  • Would not build with the tests.

@davidjharder
Copy link
Member

I suspect the test are failing because tests now require additional packages, one of which is not packaged by solus (zope.testing and zope.testrunner)

https://github.com/zopefoundation/zope.hookable/blob/00be0b33bff21fd5f4a6140f81be841d3c3d3732/setup.py#L82

@androidnisse
Copy link
Contributor Author

I suspect the test are failing because tests now require additional packages, one of which is not packaged by solus (zope.testing and zope.testrunner)

https://github.com/zopefoundation/zope.hookable/blob/00be0b33bff21fd5f4a6140f81be841d3c3d3732/setup.py#L82

So should I add the missing or just let it be without tests?

@davidjharder
Copy link
Member

@joebonrichie could you chime in here

@silkeh silkeh added the hacktoberfest-accepted This PR is accepted for Hacktoberfest label Oct 31, 2024
**Summary**

- C extension now enables multi-phase module initialization (PEP 489). For CPython >= 3.11, the hookable type is now a heap-allocated type.
- Drop support for Python 3.7.
- Add support for Python 3.13.
@androidnisse
Copy link
Contributor Author

Should work now @davidjharder @joebonrichie

Copy link
Member

@davidjharder davidjharder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing some monitoring files, but this has waited long enough

@davidjharder davidjharder merged commit 8b11d8a into getsolus:main Dec 10, 2024
1 check passed
@androidnisse androidnisse deleted the update_pzh branch December 13, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hacktoberfest-accepted This PR is accepted for Hacktoberfest

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants