Skip to content

Commit

Permalink
Fix responsiveness of app settings modal
Browse files Browse the repository at this point in the history
  • Loading branch information
nmfretz authored and lukechilds committed Nov 23, 2024
1 parent 6b36f23 commit ba3e13a
Showing 1 changed file with 11 additions and 7 deletions.
18 changes: 11 additions & 7 deletions packages/ui/src/modules/app-store/select-dependencies-dialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -252,21 +252,25 @@ function DependencyDropdown({
return (
<DropdownMenu open={openDropdowns[dependencyId] ?? false} onOpenChange={onOpenChange}>
<DropdownMenuTrigger asChild className={cn(highlightDependency === dependencyId && 'umbrel-pulse-a-few-times')}>
<Button className='h-[40px] min-w-[256px] px-4'>
<span className='flex flex-1 flex-row items-center gap-2 text-[14px]'>
<Button className='h-[40px] w-[256px] max-w-[calc(100%-90px)] px-4'>
<div className='flex min-w-0 flex-1 items-center gap-2 text-left'>
{selectedApp ? (
<>
{selectedApp.icon && <AppIcon size={26} src={selectedApp.icon} className='rounded-6' />}
{selectedApp.name}
{selectedApp.icon && <AppIcon size={26} src={selectedApp.icon} className='shrink-0 rounded-6' />}
<div className='min-w-0 flex-1'>
<span className='block truncate text-[14px]'>{selectedApp.name}</span>
</div>
</>
) : (
t('app-picker.select-app')
<div className='min-w-0 flex-1'>
<span className='block truncate text-[14px]'>{t('app-picker.select-app')}</span>
</div>
)}
</span>
</div>
<ChevronDown />
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent className='flex max-h-72 min-w-[256px] flex-col gap-3' align='start'>
<DropdownMenuContent className='flex max-h-72 w-[256px] flex-col gap-3' align='start'>
<ScrollArea className='relative -mx-2.5 flex h-full flex-col px-2.5'>
{alternatives.map(({app}) => (
<DropdownMenuCheckboxItem
Expand Down

0 comments on commit ba3e13a

Please sign in to comment.