Skip to content

Update build.yml - #520

Merged
rzhade3 merged 4 commits into
mainfrom
fix-build-job
Aug 8, 2024
Merged

rzhade3 merged 4 commits into
mainfrom
fix-build-job

Conversation

@boveus

@boveus boveus commented Aug 8, 2024 •

Copy link
Copy Markdown
Contributor

All PRs:

  • Has tests N/A
  • Documentation updated N/A

Adding a new header

Generally, adding a new header is always OK.

  • Is the header supported by any user agent? If so, which?
  • What does it do?
  • What are the valid values for the header?
  • Where does the specification live?

Adding a new CSP directive

  • Is the directive supported by any user agent? If so, which?
  • What does it do?
  • What are the valid values for the directive?

Comment thread .github/workflows/build.yml Fixed
Comment thread .github/workflows/build.yml Fixed
Comment thread .github/workflows/build.yml Outdated
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
- name: Install Bundler

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bundler is automatically installed with the ruby/setup-ruby action, including with this conditional.

@rzhade3 rzhade3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears as if we're running into some Coveralls errors in CI:

Screenshot 2024-08-08 at 7 50 58 PM

We should either fix this error, or remove the dependency on Coveralls. However, 👍 on this PR to fix builds in production.

@rzhade3
rzhade3 merged commit b122c2f into main Aug 8, 2024
@rzhade3
rzhade3 deleted the fix-build-job branch August 8, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants