-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: svg border #319
chore: svg border #319
Conversation
✅ Deploy Preview for gokarna-hugo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@yashmehrotra The mail icon is not visible after the changes in this PR. Check deploy preview: Also, the border lines look blurry for some reason: |
@ 93eb62c Tested locally - no obvious regressions. @yashmehrotra How are you testing the Bluesky icon? Can you provide a diff patch, please? |
@jamesericdavidson Downloaded the bluesky icon from simpleicons, and config.toml looks like: [[menu.main]]
identifier = "bluesky"
pre = "<img class='svg-inject' src='/https/github.com/icons/bluesky.svg' />"
url = "https://bsky.app/profile/yashmehrotra.com" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@yashmehrotra @526avijitgupta Should we support |
@jamesericdavidson That is already mentioned in the docs |
Should we merge this? @yashmehrotra @jamesericdavidson |
Yes 👍 @526avijitgupta |
cc: @jamesericdavidson