Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: svg border #319

Merged
merged 2 commits into from
Feb 8, 2025
Merged

chore: svg border #319

merged 2 commits into from
Feb 8, 2025

Conversation

yashmehrotra
Copy link
Collaborator

@yashmehrotra yashmehrotra commented Jan 29, 2025

Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for gokarna-hugo ready!

Name Link
🔨 Latest commit 93eb62c
🔍 Latest deploy log https://app.netlify.com/sites/gokarna-hugo/deploys/679a4c137299f60008be7328
😎 Deploy Preview https://deploy-preview-319--gokarna-hugo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yashmehrotra
Copy link
Collaborator Author

image

vs

image

@526avijitgupta
Copy link
Member

@yashmehrotra The mail icon is not visible after the changes in this PR. Check deploy preview:

image

Also, the border lines look blurry for some reason:

image

@jamesericdavidson
Copy link
Contributor

jamesericdavidson commented Jan 30, 2025

@ 93eb62c Tested locally - no obvious regressions.

@yashmehrotra How are you testing the Bluesky icon? Can you provide a diff patch, please?

@yashmehrotra
Copy link
Collaborator Author

@jamesericdavidson Downloaded the bluesky icon from simpleicons, and config.toml looks like:

    [[menu.main]]
    identifier = "bluesky"
    pre = "<img class='svg-inject' src='/https/github.com/icons/bluesky.svg' />"
    url = "https://bsky.app/profile/yashmehrotra.com"

Copy link
Member

@526avijitgupta 526avijitgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 🚀

Copy link
Contributor

@jamesericdavidson jamesericdavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamesericdavidson
Copy link
Contributor

jamesericdavidson commented Feb 1, 2025

@yashmehrotra @526avijitgupta Should we support svg-inject and user-specified SVG icon sets in the advanced docs?

@yashmehrotra
Copy link
Collaborator Author

@jamesericdavidson That is already mentioned in the docs

https://gokarna-hugo.netlify.app/posts/theme-documentation-advanced/#icons-in-header

@526avijitgupta
Copy link
Member

Should we merge this? @yashmehrotra @jamesericdavidson

@jamesericdavidson
Copy link
Contributor

Should we merge this? @yashmehrotra @jamesericdavidson

Yes 👍 @526avijitgupta

@yashmehrotra yashmehrotra merged commit bc4ea71 into main Feb 8, 2025
4 checks passed
@yashmehrotra yashmehrotra deleted the svg-update branch February 8, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants