-
Notifications
You must be signed in to change notification settings - Fork 457
chore(example): context propagation and signal-based cancellation #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ation - Add signal handling to gracefully cancel the context on interrupt (SIGINT, SIGTERM) - Update functions to accept context instead of creating a new one internally - Pass the main context to MCP transport constructors for improved cancellation support Signed-off-by: appleboy <[email protected]>
Summary of ChangesHello @appleboy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a great improvement, refactoring the MCP example to properly propagate context and handle termination signals for graceful cancellation. The changes are clean and follow Go best practices. I have one suggestion to improve the portability of the signal handling code.
- Remove unused import of syscall - Create cancellation context only for SIGINT (Ctrl+C), not SIGTERM Signed-off-by: appleboy <[email protected]>
dpasiukevich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
All examples use in-memory services, so the data will be lost anyway. Let's only add it to MCP example (where it's needed for github mcp flow)?
Thanks!
|
@dpasiukevich revert the last commit. Thanks for your feedback. |
- Use Go-style octal notation (0o) for file permission arguments in os.MkdirAll and os.WriteFile - Remove a few unnecessary blank lines at the end of main functions Signed-off-by: appleboy <[email protected]>
dpasiukevich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@dpasiukevich can you merge the PR? |
|
@appleboy it should be possible to merge yourself, you only needed to mark comments as resolved. Let me know if that was not the case. |
Uh oh!
There was an error while loading. Please reload this page.