Skip to content

Conversation

@appleboy
Copy link
Contributor

@appleboy appleboy commented Nov 8, 2025

  • Add signal handling to gracefully cancel the context on interrupt (SIGINT)
  • Update functions to accept context instead of creating a new one internally
  • Pass the main context to MCP transport constructors for improved cancellation support

…ation

- Add signal handling to gracefully cancel the context on interrupt (SIGINT, SIGTERM)
- Update functions to accept context instead of creating a new one internally
- Pass the main context to MCP transport constructors for improved cancellation support

Signed-off-by: appleboy <[email protected]>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @appleboy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the mcp example to enhance its robustness and responsiveness to system signals. It introduces a centralized context that can be cancelled via SIGINT or SIGTERM, and propagates this context throughout the MCP transport initialization and connection processes. This ensures that long-running operations and network clients can be gracefully shut down when the application receives an interrupt signal, improving overall application stability.

Highlights

  • Signal-based Context Cancellation: The application now gracefully handles interrupt signals (SIGINT, SIGTERM) by integrating signal.NotifyContext into the main context, ensuring proper shutdown of ongoing operations.
  • Improved Context Propagation: Functions responsible for creating MCP transports (localMCPTransport, githubMCPTransport) have been refactored to accept and utilize a context.Context parameter, replacing internal context.Background() calls for better cancellation support.
  • Enhanced MCP Transport Initialization: The main application context is now explicitly passed to MCP transport constructors, allowing for consistent cancellation behavior across the application's lifecycle, including network clients and in-memory servers.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a great improvement, refactoring the MCP example to properly propagate context and handle termination signals for graceful cancellation. The changes are clean and follow Go best practices. I have one suggestion to improve the portability of the signal handling code.

- Remove unused import of syscall
- Create cancellation context only for SIGINT (Ctrl+C), not SIGTERM

Signed-off-by: appleboy <[email protected]>
@appleboy appleboy changed the title refactor(mcp): integrate context propagation and signal-based cancellation chore(example): context propagation and signal-based cancellation Nov 8, 2025
Copy link
Collaborator

@dpasiukevich dpasiukevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

All examples use in-memory services, so the data will be lost anyway. Let's only add it to MCP example (where it's needed for github mcp flow)?

Thanks!

@appleboy
Copy link
Contributor Author

appleboy commented Nov 8, 2025

@dpasiukevich revert the last commit. Thanks for your feedback.

- Use Go-style octal notation (0o) for file permission arguments in os.MkdirAll and os.WriteFile
- Remove a few unnecessary blank lines at the end of main functions

Signed-off-by: appleboy <[email protected]>
Copy link
Collaborator

@dpasiukevich dpasiukevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@appleboy
Copy link
Contributor Author

@dpasiukevich can you merge the PR?

@dpasiukevich dpasiukevich merged commit cbf8d4f into google:main Nov 10, 2025
3 checks passed
@dpasiukevich
Copy link
Collaborator

@appleboy it should be possible to merge yourself, you only needed to mark comments as resolved. Let me know if that was not the case.

@appleboy appleboy deleted the mcp branch November 10, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants