Restructure the REST API packages #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
529aa8b to
b010c25
Compare
Member
Author
|
PTAL |
Collaborator
|
LGTM! Let me know if you'd like to update this PR to hide restapi entities and expose only |
Member
Author
|
I'll revisit this PR to make some changes the hide more of the public surface. I'll introduce something like |
5797441 to
f094ad0
Compare
Member
Author
|
PTAL |
Member
Author
|
We will follow up with some more changes to the launchers, but this PR is ready for review. |
Collaborator
|
adk-docs /examples/go should be updated after we merge: for sure cloud-run and a2a_basic/remote_a2a/check_prime_agent, maybe more |
kdroste-google
previously approved these changes
Nov 13, 2025
Collaborator
kdroste-google
left a comment
There was a problem hiding this comment.
LGTM. One extra file (eval.go) to be deleted if not needed.
Member
Author
|
Can I have LGTM again? I had to rebase. |
baptmont
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server/restapitoserver/adkrestto matchserver/adka2a.server/handlerstoserver/controllersbecause it contains controllers.TODO: Consider moving controllers into an internal package.