Skip to content

Conversation

@rakyll
Copy link
Member

@rakyll rakyll commented Nov 12, 2025

Beacuse there will be other protocols we will have to support soon, and implement new Agent implementations. We can provide all first class remote agent implementations from this package.

@rakyll rakyll requested a review from dpasiukevich November 12, 2025 05:33
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rakyll, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a refactoring effort within the remoteagent package, specifically by renaming the New function to NewA2A. This change is motivated by the anticipation of supporting additional protocols and agent implementations in the future, ensuring that each protocol can have its own distinct and clearly named constructor. The update improves code clarity and prepares the codebase for greater extensibility without introducing new functionality.

Highlights

  • Function Renaming: The primary constructor function New in the remoteagent package has been renamed to NewA2A to explicitly indicate its association with the Agent-To-Agent (A2A) protocol.
  • Test Code Updates: Corresponding changes were made in the test files, including renaming the mockExecutor struct to mockA2AExecutor and the newRemoteAgent helper function to newA2ARemoteAgent, along with updating all calls to the renamed functions.
  • Example Usage Update: The example usage in examples/a2a/main.go was updated to call the newly named remoteagent.NewA2A function.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors remoteagent.New to remoteagent.NewA2A to better accommodate future protocol support. The changes are well-executed across the codebase, including in the main logic, tests, and examples. I've noted a few minor inconsistencies in test error messages that should be updated to reflect the renaming.

Beacuse there will be other protocols we will have to support soon, and implement new Agent implementations. We can provide all first class remote agent implementations from this package.
mazas-google
mazas-google previously approved these changes Nov 12, 2025
@rakyll
Copy link
Member Author

rakyll commented Nov 12, 2025

Nice catch from GCA, fixed them all. PTAL.

@rakyll rakyll merged commit f7322b1 into main Nov 12, 2025
3 checks passed
@rakyll rakyll deleted the a2aremote branch November 12, 2025 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants