Skip to content

Conversation

@kdroste-google
Copy link
Collaborator

No description provided.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @kdroste-google, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces enhanced flexibility for the web launcher by making server timeouts configurable. Previously, these timeouts were fixed, but now they can be dynamically set via new command-line parameters. This change allows for more granular control over the server's behavior, enabling administrators to fine-tune responsiveness and resource management according to specific operational requirements.

Highlights

  • Configurable Server Timeouts: New fields (writeTimeout, readTimeout, idleTimeout) have been added to the webConfig struct to store server timeout durations, making these values configurable.
  • Dynamic Timeout Application: The http.Server configuration now utilizes the newly added webConfig fields for WriteTimeout, ReadTimeout, and IdleTimeout, replacing previously hardcoded values.
  • Command-Line Parameters: New command-line flags (--write-timeout, --read-timeout, --idle-timeout) have been introduced, allowing users to specify server timeout values directly when launching the web server.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces command-line parameters for configuring server timeouts (writeTimeout, readTimeout, idleTimeout) in the web launcher. The changes are well-implemented, replacing hardcoded values with configurable ones from the webConfig struct, which are populated via new command-line flags. My review includes a suggestion to also add ReadHeaderTimeout for more granular control over server behavior, which would involve small additions to the config struct, flag parsing, and server initialization.

@kdroste-google kdroste-google merged commit 9992414 into google:main Nov 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

server/web: HTTP WriteTimeout/ReadTimeout hardcoded at 15 seconds breaks long streaming responses

4 participants