Refactor: extract repeated values into named constants

[D-sense]

This PR does the following refactoring:

1. Extract repeated values into named constants.
2. Fix TraceMergedToolCalls() comment.

[gemini-code-assist]

Summary of Changes

Hello @D-sense, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing the maintainability and clarity of the telemetry module by refactoring repeated string literals into named constants. This change centralizes frequently used values, making the code easier to understand and less prone to inconsistencies. Additionally, a minor correction was made to a function comment. The inclusion of .idea files addresses local IDE configuration, which is separate from the core refactoring effort.

Highlights

• Code Refactoring: Extracted numerous repeated string literals used as telemetry attribute keys and values into named constants within internal/telemetry/telemetry.go. This improves code readability and maintainability by centralizing these values.
• Telemetry Function Updates: Replaced hardcoded string values with the newly defined constants across the TraceMergedToolCalls, TraceToolCall, and TraceLLMCall functions, ensuring consistency and reducing potential for errors.
• Comment Correction: Corrected a comment for the TraceMergedToolCalls function to accurately reflect its purpose.
• IDE Configuration Files: Added several .idea configuration files (.gitignore, adk-go.iml, modules.xml, vcs.xml) which are typically used for local IntelliJ IDEA project setup.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively refactors repeated string values into named constants, improving code clarity. The fix to the TraceMergedToolCalls comment is also a good catch. I've identified a recurring bug in TraceMergedToolCalls and TraceToolCall where a telemetry attribute key is duplicated, and I've left specific comments with suggestions. Also, it appears that IDE-specific files from the .idea directory have been included. These should typically be excluded from version control by adding .idea/ to the project's root .gitignore file and removing them from this PR.

[D-sense]

Code Review

This pull request effectively refactors repeated string values into named constants, improving code clarity. The fix to the TraceMergedToolCalls comment is also a good catch. I've identified a recurring bug in TraceMergedToolCalls and TraceToolCall where a telemetry attribute key is duplicated, and I've left specific comments with suggestions. Also, it appears that IDE-specific files from the .idea directory have been included. These should typically be excluded from version control by adding .idea/ to the project's root .gitignore file and removing them from this PR.

The .idea directory has been untracked and excluded.

[D-sense]

This is ready for review when someone gets a chance!

[mazas-google]

LGTM. Thanks for the contribution!