-
Notifications
You must be signed in to change notification settings - Fork 457
all: run golangci-lint fmt happy #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @zchee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces gofumpt for code formatting and applies its rules across the codebase. The changes primarily consist of import reordering, parameter grouping, and other stylistic improvements that enhance code consistency and readability. The configuration in .golangci.yml looks correct. Overall, this is a great step towards maintaining a consistent code style. I've added a few comments to highlight some of the beneficial changes.
dpasiukevich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit and we can merge.
Thanks for the PR!
36c73a7 to
4ea8916
Compare
|
@dpasiukevich Fixed. PTAL. |
Signed-off-by: Koichi Shiraishi <[email protected]>
$ go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest fmt Signed-off-by: Koichi Shiraishi <[email protected]>
4ea8916 to
c6d8ffd
Compare
|
@dpasiukevich Resolve conflict. PTALA. |
dpasiukevich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Format import section
$ go run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest fmt