Skip to content

Conversation

@yarolegovich
Copy link
Member

@yarolegovich yarolegovich commented Nov 27, 2025

Added BeforeA2ARequestCallback, A2AEventConverter and AfterA2ARequestCallback to remoteagent.A2AConfig.

BeforeA2ARequestCallback allows to modify a request or prevent it by returning a non-nil event or error which becomes the result of agent invocation.

A2AEventConverter allows to implement a custom conversion.

AfterA2ARequestCallback allows to enrich the result of the conversion, overwrite it or reject a response.

Additionally, replaced gRPC transport in tests with JSONRPC because of an easier setup.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yarolegovich, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the flexibility of remote agent interactions by introducing pre- and post-request callback mechanisms within the remoteagent.A2AConfig. These new callbacks empower developers to inject custom logic at critical points in the request-response lifecycle, allowing for advanced request manipulation, response enrichment, and conditional processing. Concurrently, the underlying test infrastructure has been streamlined through a migration to JSONRPC, simplifying future development and testing efforts.

Highlights

  • New Request Callbacks: Introduced BeforeA2ARequestCallback and AfterA2ARequestCallback types to remoteagent.A2AConfig. These callbacks allow for intercepting and modifying requests before they are sent to a remote agent, and enriching or overwriting responses after they are received.
  • Pre-Request Logic: The BeforeA2ARequestCallback enables custom logic to inspect, log, or modify the outgoing request. It can also be used to prevent the actual remote agent call by returning a non-nil event or error, facilitating caching mechanisms or early exit conditions.
  • Post-Response Processing: The AfterA2ARequestCallback is invoked after receiving a response (for every event in streaming responses). This callback provides an opportunity to log responses, collect metrics, perform pre-processing of events, or even completely overwrite or reject the original response.
  • Test Infrastructure Refactoring: The test suite's transport mechanism has been migrated from gRPC to JSONRPC. This change simplifies the test setup and improves maintainability by removing gRPC-specific dependencies and configurations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces BeforeA2ARequestCallback and AfterA2ARequestCallback to the remoteagent.A2AConfig, enhancing extensibility by allowing modification of requests and responses. The changes are well-implemented, and the accompanying tests are thorough. Additionally, the switch from gRPC to JSONRPC in tests simplifies the setup. I have a few suggestions to improve code clarity, fix a minor performance degradation in a test helper, and remove a duplicated test case.

@yarolegovich yarolegovich requested a review from baptmont December 1, 2025 12:36
baptmont
baptmont previously approved these changes Dec 1, 2025
@yarolegovich yarolegovich merged commit 319b1a8 into main Dec 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants