Skip to content

Conversation

@yarolegovich
Copy link
Member

Fix remoteagent not supporting standard agent.BeforeAgentCallback and agent.AfterAgentCallbacks.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yarolegovich, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a limitation in the remoteagent by introducing support for standard agent.BeforeAgentCallback and agent.AfterAgentCallback mechanisms. This enhancement allows developers to define and execute custom logic both before and after the remote agent's primary operation, thereby improving its extensibility and aligning its behavior with other standard agent implementations. The change primarily involves modifying the A2AConfig structure and the agent's constructor to properly register these lifecycle callbacks.

Highlights

  • Added BeforeAgentCallbacks: The A2AConfig struct now includes a BeforeAgentCallbacks field, allowing a list of agent.BeforeAgentCallback functions to be executed sequentially before the remote agent starts its run. This enables pre-processing or conditional skipping of the agent's execution.
  • Added AfterAgentCallbacks: A new AfterAgentCallbacks field has been added to the A2AConfig struct. This field accepts a list of agent.AfterAgentCallback functions that will be executed sequentially after the remote agent has completed its operation, providing a mechanism for post-processing or event generation.
  • Integrated Callbacks into Agent Creation: The NewA2A function has been updated to pass the newly introduced BeforeAgentCallbacks and AfterAgentCallbacks from the A2AConfig directly to the agent.New constructor, ensuring these standard agent lifecycle callbacks are properly registered and utilized by the remote agent.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds support for the standard BeforeAgentCallback and AfterAgentCallback to the remoteagent by plumbing them through the A2AConfig. The changes are straightforward and look correct. My main feedback is the lack of tests for this new functionality. I've added a comment suggesting to add tests to ensure these callbacks are working as expected.

@yarolegovich yarolegovich merged commit ec70ca4 into main Dec 5, 2025
3 checks passed
@yarolegovich yarolegovich deleted the yarolegovich/remoteagent-agent-callbacks branch December 5, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants