Skip to content

Conversation

@dpasiukevich
Copy link
Collaborator

Fixes #408

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dpasiukevich, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the GORM session service by standardizing timestamp precision to microseconds across all relevant database models and application logic. This change ensures data consistency, prevents potential rounding errors during storage, and aligns timestamp comparisons with the expected microsecond-level precision, ultimately resolving issues related to time discrepancies in session management.

Highlights

  • Standardized Timestamp Precision: Enforced microsecond precision for all time.Time fields in GORM models (storageSession, storageEvent, storageAppState, storageUserState) by adding gorm:"precision:6" tags, ensuring consistent database storage.
  • Timestamp Truncation: Explicitly truncates event.Timestamp to microsecond precision before persistence, preventing rounding errors and aligning with the database's expected precision.
  • Stale Session Check Alignment: Updated the stale session detection logic to use UnixMicro() instead of UnixNano() for timestamp comparisons, aligning it with the new microsecond precision standard and matching existing Python code behavior.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly implements microsecond precision for timestamps in the GORM session service. The changes involve updating GORM model struct tags to precision:6 and adjusting the application logic to handle timestamps at microsecond precision, which prevents potential rounding errors and aligns with database capabilities. The review identified a minor issue in the error logging for stale sessions, where timestamps would be formatted incorrectly. A code suggestion is provided to fix this. Overall, the changes are well-implemented and address the intended goal.

@dpasiukevich dpasiukevich merged commit 15ad4c1 into google:main Dec 11, 2025
3 checks passed
@dpasiukevich dpasiukevich deleted the db_session_precision branch December 11, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix stale session error

3 participants