Fix ineffectual assignments and error handling in tests

[muesli]

• Ignore ineffectual assignments
• Check for error when reading keyring

[codecov]

Codecov Report

Merging #1234 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1234   +/-   ##
=======================================
  Coverage   73.36%   73.36%           
=======================================
  Files          86       86           
  Lines        6026     6026           
=======================================
  Hits         4421     4421           
  Misses        836      836           
  Partials      769      769

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 955a14c...ca507d0. Read the comment docs.

[gmlewis]

Thanks, @muesli - I'm the one that wrote these additional tests for the sake of code coverage improvements. If you're going to do this, please go through and fix all the added code coverage tests so that the repo is self-consistent in style.

[muesli]

@gmlewis I don't think it would affect code coverage, but I'm happy to remove the other ineffectual assignments I can find.

[muesli]

@gmlewis Ok, hope I caught them all.

[gmlewis]

OK, looks like these changes did not affect code coverage, and my original PRs were done to improve coverage (without review), so I'm just going to go ahead and merge this as a code cleanup.
Thanks, @muesli.

[muesli]

No problem, thanks for merging!