Enable BranchRestriction fields to be empty#1530
Enable BranchRestriction fields to be empty#1530gmlewis merged 1 commit intogoogle:masterfrom michelangelomo:restriction-fields-can-be-empty
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #1530 +/- ##
=======================================
Coverage 68.03% 68.03%
=======================================
Files 94 94
Lines 8528 8528
=======================================
Hits 5802 5802
Misses 1844 1844
Partials 882 882
Continue to review full report at Codecov.
|
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @michelangelomo !
LGTM.
Awaiting second LGTM before merging.
|
Thank you, @wesleimp ! |
Description
I've encountered an issue trying to update BranchRestriction on a personal repository. Github doesn't allow
teamsandusersfields in the request payload.How to reproduce
will return
but if I set
TeamsandUsersfields as[]string{}Github returns422 Validation Failed [{Resource: Field: Code: Message:Only organization repositories can have users and team restrictions}]as described above.Fix
Allow
TeamsandUsersfields to be empty by usingomitempty.