feat: Add support for custom names and methods that return structs with multiple []*T fields in gen-iterators.go#4128
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4128 +/- ##
==========================================
+ Coverage 93.72% 93.74% +0.01%
==========================================
Files 211 211
Lines 19621 19681 +60
==========================================
+ Hits 18389 18449 +60
Misses 1034 1034
Partials 198 198 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @Not-Dhananjay-Mishra!
Just a few tweaks, please (you'll have to make these locally since the indentation and bracketing will change), then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29 - @munlicode
|
@gmlewis Thanks again! |
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @Not-Dhananjay-Mishra and @stevehipwell!
LGTM.
Merging.
With
customNamesmap we can assign custom names specifically for the iterator while keeping the original method name unchanged also with this we can give more understandable names for the iterator.and some method like
GetCommitandCompareCommitscontains multiple[]*Tfields withsliceToBeUsedForIterationmap we can specify which field should be used for iterationRelated : #4117