Conversation
The /orgs/:org GitHub API endpoint expects the string name of the organization, not its integer ID (that would be /organizations/:id endpoint, which we're generally not using). Change the org parameter type from int to string to make it possible to specify the organization via its name. This method wasn't functional before. Fixes #730.
elliott-beach
approved these changes
Sep 28, 2017
Contributor
elliott-beach
left a comment
There was a problem hiding this comment.
LGTM.
I imagine the mistake originally occurred by copying the signature from ListPendingTeamInvitations, which takes an id for the team. org is a string in all other usages.
Member
Author
Collaborator
|
Sorry for the delay... reviewing... |
nbareil
pushed a commit
to nbareil/go-github
that referenced
this pull request
May 1, 2018
…gle#731) The /orgs/:org GitHub API endpoint expects the string name of the organization, not its integer ID (that would be /organizations/:id endpoint, which we're generally not using). Change the org parameter type from int to string to make it possible to specify the organization via its name. This method wasn't functional before. Fixes google#730.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
/orgs/:orgGitHub API endpoint expects the string name of the organization, not its integer ID (that would be/organizations/:idendpoint, which we're generally not using).Change the org parameter type from int to string to make it possible to specify the organization via its name.
This method wasn't functional before.
Fixes #730.