Native pytree support in zoom line search. #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junpenglao
reviewed
Jun 28, 2022
jaxopt/_src/zoom_linesearch.py
Outdated
|
|
||
| # FIXME: directly accept a value_and_grad function to avoid recompilations. | ||
| phi, g = jax.value_and_grad(f)(xkp1) | ||
| dphi = tree_real(tree_vdot(g, pk)) |
There was a problem hiding this comment.
How often do we have this pattern? I am not sure how expensive is the additional tree map, maybe it is better to a single function that we map to the input?
real_vdot = lambda x, y: jnp.real(_vdot_safe(x, y))
tree_real_vdot = lambda x, y: tree_map(real_vdot, tree)There was a problem hiding this comment.
Good question. I wonder if JAX's jit is able to optimize this automatically. If not, happy to add the utility you suggest. BTW, we don't have good support for complex numbers in JAXopt, see #169.
There was a problem hiding this comment.
Hmm, I actually just realized that tree_real isn't necessary, just jnp.real will be enough, since tree_vdot returns a scalar.
junpenglao
approved these changes
Jun 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.