Skip to content
This repository was archived by the owner on Sep 27, 2023. It is now read-only.

chore: remove deprecated maven plugin #313

Merged
eaball35 merged 3 commits into from
Oct 14, 2021
Merged

chore: remove deprecated maven plugin #313

eaball35 merged 3 commits into from
Oct 14, 2021

Conversation

@chanseokoh
Copy link
Contributor

@chanseokoh chanseokoh commented Oct 13, 2021 •
edited
Loading

The maven Gradle plugin is deprecated. The project already applies the maven-publish plugin that supersedes it, so the maven plugin is actually redundant.

Ref: #304

@chanseokoh chanseokoh requested a review from a team as a code owner October 13, 2021 22:17
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 13, 2021
@chanseokoh chanseokoh requested a review from suztomo October 13, 2021 22:18
@chanseokoh chanseokoh changed the title Remove deprecated maven plugin chore: remove deprecated maven plugin Oct 14, 2021
@eaball35 eaball35 merged commit c82fe8a into main Oct 14, 2021
@eaball35 eaball35 deleted the remove-deprecated-plugin branch October 14, 2021 19:36
@suztomo
Copy link
Member

suztomo commented Oct 14, 2021

Looks good to me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@suztomo suztomo Awaiting requested review from suztomo

1 more reviewer

@eaball35 eaball35 eaball35 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chanseokoh @suztomo @eaball35