Skip to content

build: treat warnings as errors #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
parthea wants to merge 2 commits into from
Closed

build: treat warnings as errors #1875

parthea wants to merge 2 commits into from

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Nov 28, 2023

Fixes #1874 🦕

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Nov 28, 2023
@parthea parthea force-pushed the treat-warnings-as-errors branch from eaa648c to 3a12a03 Compare November 28, 2023 15:24
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Nov 28, 2023
@parthea parthea force-pushed the treat-warnings-as-errors branch 10 times, most recently from 2c7c00c to a1c5616 Compare November 28, 2023 17:26
@parthea parthea force-pushed the treat-warnings-as-errors branch from a1c5616 to 966d61b Compare November 28, 2023 18:01
@parthea
Copy link
Contributor Author

parthea commented Nov 28, 2023

Wait for
googleapis/python-api-common-protos#191
googleapis/proto-plus-python#391
googleapis/python-api-core#555

@parthea parthea added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 28, 2023
@parthea parthea marked this pull request as ready for review December 10, 2023 14:42
@parthea parthea requested a review from a team as a code owner December 10, 2023 14:42
@parthea parthea marked this pull request as draft December 18, 2023 18:25
@parthea parthea closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable warnings as errors when running tests

2 participants

@parthea @ohmayr