fix(spanner): context cancel in traces in case of skipping trailers#12635
Merged
fix(spanner): context cancel in traces in case of skipping trailers#12635
Conversation
daf851f to
658bb36
Compare
658bb36 to
9484eed
Compare
olavloite
reviewed
Aug 5, 2025
spanner/read.go
Outdated
| span.SetStatus(otcodes.Ok, "Stream finished successfully") | ||
| span.End() | ||
| } | ||
| go func(s streamingReceiver) { |
Contributor
There was a problem hiding this comment.
Would this change then also make it possible to move the d.cancel() call from the goroutine into the main thread (and remove the extra s.Recv() call)? Or would that then still cause either the trace or the call server-side to show up as cancelled?
Contributor
Author
There was a problem hiding this comment.
Removed the extra go routine
Contributor
Author
There was a problem hiding this comment.
iter.Stop will cancel the routine now anyways
olavloite
reviewed
Aug 5, 2025
…context in case of skip trailers
olavloite
approved these changes
Aug 5, 2025
|
@rahul2393 do you have any ETA for the latest changes release? |
Contributor
Author
|
@yordis We already released it in 1.84.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.