feat(internal/gapicgen): change commit formatting to match standard #3500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the commit formatting so that it can be parsed as a footer with a conventional commits parser. Here is an example of what a commit looked like previously: - docs(dialogflow): update comments on parameters and validation result. PiperOrigin-RevId: 348673154 Source-Link: googleapis/googleapis@0795e3f And what it will look like now: docs(dialogflow): update comments on parameters and validation result. PiperOrigin-RevId: 348673154 Source-Link: googleapis/googleapis@0795e3f
Member
Author
|
cc @bcoe . Will wait to merge this until the parser work is done. |
tbpg
suggested changes
Jan 6, 2021
Contributor
tbpg
left a comment
There was a problem hiding this comment.
High level question: looking at https://www.conventionalcommits.org/en/v1.0.0/, it seems like there should be an empty line between the first line and the next?
Member
Author
|
Related PR googleapis/release-please#686 |
@tbpg as we formalize the grammar, I've been advocating that we allow single |
bcoe
reviewed
Jan 7, 2021
tbpg
approved these changes
Jan 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the commit formatting so that it can be parsed as a footer
with a conventional commits parser. Here is an example of what a
commit looked like previously:
docs(dialogflow): update comments on parameters and validation result.
PiperOrigin-RevId: 348673154
Source-Link: googleapis/googleapis@0795e3f
And what it will look like now:
docs(dialogflow): update comments on parameters and validation result.
PiperOrigin-RevId: 348673154
Source-Link: googleapis/googleapis@0795e3f