Skip to content

Conversation

@miguelvelezsa
Copy link
Collaborator

@miguelvelezsa miguelvelezsa commented Oct 20, 2025

As short term solution we are going to run a preinstall script to be used in all github actions.
Preinstall script just install local packages individually in a topological order to avoid dependency issues.

Currently we are having an issue with npm workspaces package installation, generating a race condition between packages therefore errors because they can't find each other.

Long term solution in b/453752589

@miguelvelezsa miguelvelezsa requested a review from a team as a code owner October 20, 2025 22:04
sofisl
sofisl previously approved these changes Oct 20, 2025
@miguelvelezsa miguelvelezsa merged commit 6d83721 into main Oct 20, 2025
13 checks passed
@miguelvelezsa miguelvelezsa deleted the fix-workspace-race-condition-installing-packages branch October 20, 2025 23:40
GautamSharda pushed a commit that referenced this pull request Oct 21, 2025
miguelvelezsa added a commit that referenced this pull request Oct 23, 2025
* feat: add preinstall script

* feat: run preinstall-deps in all github actions

* fix: add --workspace attribute in install-deps script

* fix: remove gaxios from install-deps scripts

* fix: delete update-api-list.yaml

* fix: remove preinstall issues-no-repro.yaml
GautamSharda pushed a commit that referenced this pull request Oct 29, 2025
- grpc version minimum to 1.2
- fixes on paged iterations
GautamSharda pushed a commit that referenced this pull request Oct 29, 2025
- grpc version minimum to 1.2
- fixes on paged iterations
miguelvelezsa pushed a commit that referenced this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants