-
Notifications
You must be signed in to change notification settings - Fork 8
feat: add preinstall script #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
miguelvelezsa
merged 6 commits into
main
from
fix-workspace-race-condition-installing-packages
Oct 20, 2025
Merged
feat: add preinstall script #127
miguelvelezsa
merged 6 commits into
main
from
fix-workspace-race-condition-installing-packages
Oct 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofisl
reviewed
Oct 20, 2025
sofisl
reviewed
Oct 20, 2025
sofisl
previously approved these changes
Oct 20, 2025
sofisl
approved these changes
Oct 20, 2025
GautamSharda
pushed a commit
that referenced
this pull request
Oct 21, 2025
miguelvelezsa
added a commit
that referenced
this pull request
Oct 23, 2025
* feat: add preinstall script * feat: run preinstall-deps in all github actions * fix: add --workspace attribute in install-deps script * fix: remove gaxios from install-deps scripts * fix: delete update-api-list.yaml * fix: remove preinstall issues-no-repro.yaml
This was referenced Oct 23, 2025
GautamSharda
pushed a commit
that referenced
this pull request
Oct 29, 2025
- grpc version minimum to 1.2 - fixes on paged iterations
GautamSharda
pushed a commit
that referenced
this pull request
Oct 29, 2025
- grpc version minimum to 1.2 - fixes on paged iterations
miguelvelezsa
pushed a commit
that referenced
this pull request
Nov 6, 2025
miguelvelezsa
pushed a commit
that referenced
this pull request
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As short term solution we are going to run a preinstall script to be used in all github actions.
Preinstall script just install local packages individually in a topological order to avoid dependency issues.
Currently we are having an issue with npm workspaces package installation, generating a race condition between packages therefore errors because they can't find each other.
Long term solution in b/453752589