Skip to content

Add 'eventual' flag to 'Connection.lookup()' / 'Connection.run_query()'. #449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tseaver merged 4 commits into from
Dec 19, 2014
Merged

Add 'eventual' flag to 'Connection.lookup()' / 'Connection.run_query()'. #449

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a41ff58
Add 'eventual' flag to 'Connection.lookup()'/'Connection.run_query()'.
tseaver Dec 18, 2014
7ce27d2
Spell enumerated value more naturally.
tseaver Dec 19, 2014
31ab4ea
Improve variable names.
tseaver Dec 19, 2014
a2a11bd
DRY out read_options logic.
tseaver Dec 19, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve variable names. 
Feedback from @dhermes:
https://github.com/GoogleCloudPlatform/gcloud-python/pull/449/files#r22116090
  • Loading branch information
@tseaver
tseaver committed Dec 19, 2014
commit 31ab4ea84160fef3904560ba8287e344932b1bf9
8 changes: 4 additions & 4 deletions gcloud/datastore/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,14 +253,14 @@ def lookup(self, dataset_id, key_pbs,
for key_pb in key_pbs:
lookup_request.key.add().CopyFrom(key_pb)

results, m_found, d_found = self._lookup(lookup_request, dataset_id,
deferred is not None)
results, missing_found, deferred_found = self._lookup(
lookup_request, dataset_id, deferred is not None)

if missing is not None:
missing.extend(m_found)
missing.extend(missing_found)

if deferred is not None:
deferred.extend(d_found)
deferred.extend(deferred_found)

if single_key:
if results:
Expand Down