Spanner 1.0.0 Release #4846
Merged
Spanner 1.0.0 Release #4846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Updated the changelog slightly, as the gapic changes happened during the last release. |
theacodes
approved these changes
Feb 7, 2018
Contributor
Author
|
@jonparrott Should I squash it on my end and repush? otherwise it'd be hard to tag? |
Contributor
|
nah we'll squash on merge. |
Contributor
|
@chemelnucfin the system tests in the tag build failed https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/5408 this seems to just be due to flakiness considering it passed on Python 3.6, so I'm going to manually push the library to pypi, but could you take a look at the test? |
Contributor
Author
|
on it. |
Contributor
Author
|
It might be a server issue as my tests pass. I'll see if it can be retried on that error. |
Contributor
|
sounds good. thank you.
…On Wed, Feb 7, 2018 at 10:42 AM chemelnucfin ***@***.***> wrote:
It might be a server issue as my tests pass. I'll see if it can be retried
on that error.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#4846 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUc1ZgdoUg4zvWqx1Bhx-b4Cs7IFZbks5tSe6igaJpZM4R8N8k>
.
|
Contributor
Author
|
looks like the test retries on ServerErrors, which does not retry on ClientError which 409 is... |
chemelnucfin
added a commit
to chemelnucfin/google-cloud-python
that referenced
this pull request
Feb 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks @jonparrott.