Skip to content

Conversation

@supriyagarg
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2018
@supriyagarg
Copy link
Contributor Author

@jonparrott Looks like the 2 lines not covered are the ones that check if pandas exists, and sets it to None otherwise: https://github.com/GoogleCloudPlatform/google-cloud-python/blob/monitoring-autogen/monitoring/google/cloud/monitoring_v3/_dataframe.py#L21

What is a reasonable way to test this?

@tseaver
Copy link
Contributor

tseaver commented Apr 20, 2018

@supriyagarg you can just add #pragma: NO COVER to the except ImportError: line.

Also, the lint failures are:

google/cloud/monitoring_v3/__init__.py:22:80: E501 line too long (80 > 79 characters)
google/cloud/monitoring_v3/__init__.py:44:80: E501 line too long (90 > 79 characters)

@supriyagarg
Copy link
Contributor Author

@tseaver: thanks for your comments!
Fixed the coverage and lint errors.

@theacodes theacodes merged commit 3f7210a into googleapis:monitoring-autogen Apr 20, 2018
@theacodes
Copy link
Contributor

Thank you, @supriyagarg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants