Skip to content

ResourceManager: fix list_projects(filter_params) #5383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
theacodes merged 1 commit into from
May 24, 2018
Merged

ResourceManager: fix list_projects(filter_params) #5383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion resource_manager/google/cloud/resource_manager/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

"""A Client for interacting with the Resource Manager API."""

import six

from google.api_core import page_iterator
from google.cloud.client import Client as BaseClient
Expand Down Expand Up @@ -162,7 +163,10 @@ def list_projects(self, filter_params=None, page_size=None):
extra_params['pageSize'] = page_size

if filter_params is not None:
extra_params['filter'] = filter_params
extra_params['filter'] = [
'{}:{}'.format(key, value)
for key, value in six.iteritems(filter_params)
]

return page_iterator.HTTPIterator(
client=self,
Expand Down
3 changes: 2 additions & 1 deletion resource_manager/tests/unit/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,12 +217,13 @@ def test_list_projects_with_filter(self):
self.assertEqual(project.status, STATUS)

# Check that the filter made it in the request.
FLATTENED_FILTER_PARAMS = ['id:project-id']
request, = client._connection._requested
self.assertEqual(request, {
'path': '/projects',
'method': 'GET',
'query_params': {
'filter': FILTER_PARAMS,
'filter': FLATTENED_FILTER_PARAMS,
},
})

Expand Down