Logging: add support for additional 'LogEntry' fields #6229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@tseaver thanks |
Contributor
Author
Contributor
Author
|
Bigtable test flake (#6245) is unrelated to this change. |
It is set only when parsing a server response.
Eases comparison of delegated arguments.
Single-entry logger methods pass it. Batch methods do not, because the log name for batches is passed as a top-level parameter.
Returns 'None' if the payload is a protobuf message. 'ProtobufEntry.payload_pb' now returns 'None' if the payload is *not* a protobuf message. Update system tests accordingly.
11f6ef6 to
30baca5
Compare
Contributor
Author
|
Rebased to try getting Kokoro to run only for logging. |
Contributor
Author
|
@crwilcox, @chrisrossi This branch is finally right with CI, and should be ready to review once the Kokoro - Logging job completes. |
chrisrossi
reviewed
Oct 22, 2018
chrisrossi
approved these changes
Oct 22, 2018
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Use namedtuples to reduce boilerplate in 'logger.Batch', 'logger.Logger', and 'entries' implementations: remove 'entry_type' and 'PAYLOAD_KEY' warts, dispatching instead based on class to load / save payload. Parse 'LogEntry.receiveTimestamp' -> 'received_timestamp' attr. Make 'received_timestamp' default to 'None' for all instances. It is set only when parsing a server response. Add support for 'LogEntry.traceSampled' field. Add support for 'source_location' field of log entries. Add support for 'operation' field of log entries. Add 'ProtobufEntry.payload_json': Returns 'None' if the payload is a protobuf message. 'ProtobufEntry.payload_pb' now returns 'None' if the payload is *not* a protobuf message. Drop 'EmptyEntry': just use 'LogEntry'. Closes #5601. Closes #6094.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @salrashid123.
Note that this PR refactors the log entry implementation pretty heavily: log entry classes are now based on named tuples, and should be a) smaller, b) faster, and c) better documented.
Closes #5601 (includes its commits).
Closes #6094.