Skip to content

Generate Security Center Client Library #6356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 13 commits into from
Nov 1, 2018
Merged

Generate Security Center Client Library #6356

tseaver merged 13 commits into from
Nov 1, 2018

Conversation

@crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Nov 1, 2018

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2018
tseaver
tseaver suggested changes Nov 1, 2018
View reviewed changes
@tseaver tseaver mentioned this pull request Nov 1, 2018
Merged
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2018
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2018
tseaver
tseaver reviewed Nov 1, 2018
View reviewed changes
securitycenter/google/cloud/securitycenter_v1beta1/types.py Outdated
from google.cloud.securitycenter_v1beta1.proto import security_marks_pb2
from google.cloud.securitycenter_v1beta1.proto import securitycenter_service_pb2
from google.cloud.securitycenter_v1beta1.proto \
import securitycenter_service_pb2

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@crwilcox crwilcox mentioned this pull request Nov 1, 2018
Closed
@tseaver tseaver mentioned this pull request Nov 1, 2018
Merged
@tseaver
Copy link
Contributor

tseaver commented Nov 1, 2018

PR is missing .coveragerc. The ones for other pure-autogen libs look like:

[run]
branch = True

[report]
fail_under = 100
show_missing = True
exclude_lines =
    # Re-enable the standard pragma
    pragma: NO COVER
    # Ignore debug-only repr
    def __repr__
omit =
  */gapic/*
  */proto/*

@tseaver
Copy link
Contributor

tseaver commented Nov 1, 2018

The Bigtable failure is known-flaky #6245.

@tseaver tseaver merged commit bebbb07 into googleapis:master Nov 1, 2018
@crwilcox crwilcox deleted the securitycenter branch November 1, 2018 22:09
parthea pushed a commit that referenced this pull request Jun 4, 2023
@crwilcox @tseaver
Generate Security Center Client Library (#6356)
ab26f13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crwilcox @tseaver @googlebot @kokoro-team