Skip to content

Bigtable: Run instance_admin system tests on a separate instance from table_admin and data system tests. #6579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crwilcox merged 4 commits into from
Mar 8, 2019
Merged

Bigtable: Run instance_admin system tests on a separate instance from table_admin and data system tests. #6579

crwilcox merged 4 commits into from
Mar 8, 2019

Conversation

@AVaksman
Copy link
Contributor

@AVaksman AVaksman commented Nov 19, 2018

Suggestion to fix #5928
If the problem is because main instance becomes flagged as replicated after creating and deleting an additional replicated cluster in the course of instance_admin tests, than perhaps running table_admin and data tests on a separate instance would eliminate flakes

@AVaksman AVaksman requested a review from crwilcox as a code owner November 19, 2018 22:00
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2018
@AVaksman AVaksman changed the title Run table_admin and data system tests on a separate instances Run instance_admin system tests on a separate instance from table_admin and data system tests. Nov 19, 2018
@AVaksman AVaksman force-pushed the bigtable-system-flake branch from 9b6c862 to e3f8eea Compare November 20, 2018 05:00
@AVaksman AVaksman changed the title Run instance_admin system tests on a separate instance from table_admin and data system tests. Bigtable: Run instance_admin system tests on a separate instance from table_admin and data system tests. Nov 20, 2018
@tseaver tseaver added codegen api: bigtable Issues related to the Bigtable API. and removed codegen api: bigtable Issues related to the Bigtable API. labels Nov 21, 2018
@AVaksman AVaksman force-pushed the bigtable-system-flake branch from e3f8eea to aedb905 Compare December 2, 2018 05:31
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2019
@crwilcox
Copy link
Contributor

crwilcox commented Jan 4, 2019

@AVaksman force running the tests. Is this an often flake that running the tests multiple times would find?

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 4, 2019
@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 1, 2019
@AVaksman AVaksman force-pushed the bigtable-system-flake branch from aedb905 to 6010573 Compare February 4, 2019 04:38
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 7, 2019
@AVaksman AVaksman force-pushed the bigtable-system-flake branch from 6010573 to dea8f82 Compare February 12, 2019 19:24
@AVaksman
Copy link
Contributor Author

AVaksman commented Feb 12, 2019 •
edited
Loading

@crwilcox
While running snippet tests, I have noticed that after flagging bigtable instance as replicated (create an additional cluster) even after deleting the replicated cluster methods such as table.delete and table.drop_by_prefix would fail if run right after. That issue was solved by running instance_admin and table_admin tests on separate bigtable instances.

@AVaksman
Copy link
Contributor Author

AVaksman commented Feb 13, 2019

Unrelated lint issue is addressed in separate PR #7312. Once #7312 lands this PR will pass all the checks.

@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 20, 2019
@crwilcox crwilcox merged commit fd178d6 into googleapis:master Mar 8, 2019
@tseaver tseaver mentioned this pull request Jun 18, 2019
Closed
parthea pushed a commit that referenced this pull request Nov 22, 2025
@AVaksman @crwilcox
Bigtable: Run instance_admin system tests on a separate instance from…
e715e64 
… table_admin and data system tests. (#6579)

* Add separate instance for table admin and data tests:
* instance_data to to type dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API. cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bigtable: 'test_create_instance_w_two_clusters' flakes with '504 Deadline Exceeded'

7 participants

@AVaksman @crwilcox @sduskis @tseaver @googlebot @yoshi-automation @yoshi-kokoro