Skip to content

Allow passing rpc_metadata as part of creating a bidi#7514

Merged
crwilcox merged 5 commits intogoogleapis:masterfrom
crwilcox:add-metadata-bidi
Mar 27, 2019
Merged

Allow passing rpc_metadata as part of creating a bidi#7514
crwilcox merged 5 commits intogoogleapis:masterfrom
crwilcox:add-metadata-bidi

Conversation

@crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Mar 14, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 14, 2019
tseaver
tseaver suggested changes Mar 18, 2019
View reviewed changes
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Mar 21, 2019
@googlebot
Copy link

googlebot commented Mar 26, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Mar 26, 2019
@crwilcox crwilcox force-pushed the add-metadata-bidi branch from 416dcd4 to 6304ae6 Compare March 26, 2019 18:52
@googlebot
Copy link

googlebot commented Mar 26, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 26, 2019
tseaver
tseaver reviewed Mar 26, 2019
View reviewed changes
@crwilcox crwilcox force-pushed the add-metadata-bidi branch from 6773468 to 4f16bdb Compare March 26, 2019 22:47
@crwilcox crwilcox merged commit 7f1cfee into googleapis:master Mar 27, 2019
parthea pushed a commit that referenced this pull request Nov 24, 2025
@crwilcox
Allow passing metadata as part of creating a bidi (#7514)
4728529 
* allows providing rpc metadata for bidi streams
parthea pushed a commit that referenced this pull request Nov 24, 2025
@crwilcox
Allow passing metadata as part of creating a bidi (#7514)
f0c1060 
* allows providing rpc metadata for bidi streams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alixhami alixhami Awaiting requested review from alixhami

@theacodes theacodes Awaiting requested review from theacodes

@tswast tswast Awaiting requested review from tswast

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crwilcox @googlebot @tseaver @yoshi-automation