Skip to content

Pub/Sub (nit): wrong var name in sample #7705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 1 commit into from
Apr 15, 2019
Merged

Pub/Sub (nit): wrong var name in sample #7705

sduskis merged 1 commit into from
Apr 15, 2019

Conversation

@anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Apr 15, 2019

No description provided.

@anguillanneuf anguillanneuf requested a review from crwilcox as a code owner April 15, 2019 17:27
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 15, 2019
@sduskis
Copy link
Contributor

sduskis commented Apr 15, 2019

Would this have been caught with better testing?

@anguillanneuf
Copy link
Contributor Author

anguillanneuf commented Apr 15, 2019

@sduskis This code snippet is in the docstring. It's probably why we didn't catch it earlier.

@sduskis sduskis merged commit a9e346f into googleapis:master Apr 15, 2019
@anguillanneuf anguillanneuf deleted the patch-1 branch April 16, 2019 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@sduskis sduskis sduskis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anguillanneuf @sduskis @googlebot