Skip to content

Spanner: add backoff for `run_in_transaction' when backend does not provide 'RetryInfo' in response. #8461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 6 commits into from
Jul 8, 2019
Merged

Spanner: add backoff for `run_in_transaction' when backend does not provide 'RetryInfo' in response. #8461

tseaver merged 6 commits into from
Jul 8, 2019

Conversation

@IlyaFaer
Copy link

@IlyaFaer IlyaFaer commented Jun 21, 2019

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 21, 2019
IlyaFaer
IlyaFaer commented Jun 21, 2019
View reviewed changes
IlyaFaer
IlyaFaer commented Jun 21, 2019
View reviewed changes
@IlyaFaer IlyaFaer marked this pull request as ready for review June 21, 2019 14:42
crwilcox
crwilcox suggested changes Jun 21, 2019
View reviewed changes
IlyaFaer
IlyaFaer commented Jun 24, 2019
View reviewed changes
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 28, 2019
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@crwilcox
Copy link
Contributor

crwilcox commented Jul 1, 2019

@IlyaFaer this looks good, but coverage is missing for

google/cloud/spanner_v1/session.py                     126      1     40      2    98%   346, 345->346, 349->exit

@IlyaFaer
Copy link
Author

IlyaFaer commented Jul 2, 2019

@crwilcox , okey, I've added two more tests for delay helper itself, and my local coverage says, it's 100% now

@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 3, 2019
@yoshi-automation yoshi-automation removed the 🚨 This issue needs some love. label Jul 3, 2019
@IlyaFaer
Copy link
Author

IlyaFaer commented Jul 4, 2019

@crwilcox, made commit with black reformat. Sorry, I have a habit of writing in single quotes

@AVaksman AVaksman added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 4, 2019
@tseaver tseaver changed the title Spanner: Python client not backing off on retries when RetryInfo not … Spanner: add backoff for `run_in_transaction' when backend does not provide 'RetryInfo' in response. Jul 8, 2019
@tseaver tseaver merged commit 56358af into googleapis:master Jul 8, 2019
@tseaver tseaver mentioned this pull request Jul 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frankyn frankyn Awaiting requested review from frankyn

@tseaver tseaver Awaiting requested review from tseaver

1 more reviewer

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@IlyaFaer @crwilcox @tseaver @googlebot @AVaksman @yoshi-automation @yoshi-kokoro