Skip to content

Cloud Asset: update vpcsc test settings. #8627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
busunkim96 merged 2 commits into from
Jul 10, 2019
Merged

Cloud Asset: update vpcsc test settings. #8627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17a9449
Cloud Asset: update vpcsc test settings.
gaogaogiraffe Jul 9, 2019
4e75077
Cloud Asset VPC SC Test: set GOOGLE_CLOUD_TESTS_IN_VPCSC as true in n…
gaogaogiraffe Jul 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions asset/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,9 @@ def system(session):

# Additional setup for VPCSC system tests
env = {
"PROJECT_ID": "secure-gcp-test-project-4",
"GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECT": os.environ.get(
"PROJECT_ID"
),
"PROJECT_ID": os.environ.get("PROJECT_ID"),
"GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECT": "secure-gcp-test-project-4",
"GOOGLE_CLOUD_TESTS_IN_VPCSC": "true",
}

# Run py.test against the system tests.
Expand Down
2 changes: 1 addition & 1 deletion asset/tests/system/test_vpcsc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
PROJECT_OUTSIDE = os.environ.get(
"GOOGLE_CLOUD_TESTS_VPCSC_OUTSIDE_PERIMETER_PROJECT", None
)
IS_INSIDE_VPCSC = os.environ.get("GOOGLE_CLOUD_TESTS_IN_VPCSC", "false")
IS_INSIDE_VPCSC = os.environ.get("GOOGLE_CLOUD_TESTS_IN_VPCSC", "true")


class TestVPCServiceControl(object):
Expand Down