Skip to content

Conversation

@busunkim96
Copy link
Contributor

No description provided.

@busunkim96 busunkim96 added the api: automl Issues related to the AutoML API. label Oct 2, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 2, 2019
@busunkim96 busunkim96 requested a review from sirtorry October 2, 2019 20:13
@tseaver
Copy link
Contributor

tseaver commented Oct 3, 2019

@busunkim96 How are you fixing the b0rken changes to setup.py? When I run synthtool inside the automl/ directory, I'm still seeing that change.

@busunkim96
Copy link
Contributor Author

Is something off with the setup.py? I think the synth script is written to not copy it

# ----------------------------------------------------------------------------
# Generate automl GAPIC layer
# ----------------------------------------------------------------------------
for version in versions:
library = gapic.py_library("automl", version, include_protos=True)
s.move(library / f"google/cloud/automl_{version}")
s.move(library / f"tests/unit/gapic/{version}")
s.move(library / f"docs/gapic/{version}")

@tseaver
Copy link
Contributor

tseaver commented Oct 4, 2019

@busunkim96 I mistyped: the bad changes I'm seeing are in docs/conf.py.

@busunkim96
Copy link
Contributor Author

Ah, I just manually avoided committing it. :) Hopefully the monolith is released soon.

@tseaver
Copy link
Contributor

tseaver commented Oct 4, 2019

Looks like the fix for the requests intersphinx URL finally landed in artman today: maybe you were using a pre-released version?

@busunkim96 busunkim96 merged commit 2fef1e6 into googleapis:master Oct 4, 2019
parthea pushed a commit that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: automl Issues related to the AutoML API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants