Skip to content

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented Oct 24, 2019

This code sample initiates a scripting job and then demonstrates how to
fetch the results and the child jobs.

Removes system test for scripting, as it's redundant with the code
sample.

This code sample initiates a scripting job and then demonstrates how to
fetch the results and the child jobs.

Removes system test for scripting, as it's redundant with the code
sample.
@tswast tswast requested review from a team, plamut and shollyman October 24, 2019 20:40
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 24, 2019
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, apart from the remark @tseaver gave.

(disclaimer: I wrote the original system test that this sample is based on)

@tswast tswast requested review from plamut and tseaver October 25, 2019 22:47
Copy link
Contributor

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@tswast tswast merged commit 8e7e89c into googleapis:master Oct 28, 2019
@tswast tswast deleted the stackoverflow-58494128-procedure branch October 28, 2019 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants