Skip to content

Deprecate plusForSpace#959

Merged
elharo merged 1 commit intomasterfrom
new
Jan 26, 2020
Merged

Deprecate plusForSpace#959
elharo merged 1 commit intomasterfrom
new

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Jan 24, 2020

@chingor13 @frankyn This should be fully backwards compatible at an an API and behavior level. However it does strongly warn developers not to encode spaces as plus. I'd prefer to disable that completely, but the last time we tried that it broke some downstream projects, so this is a more nudging approach to get clients to stop doing this.

@elharo elharo requested review from a team and chingor13 January 24, 2020 18:59
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 24, 2020
@frankyn
Copy link

frankyn commented Jan 24, 2020

@elharo could you verify which google projects are using this?

I'd prefer not having customers start seeing deprecation warnings that we didn't prepare for first.

@elharo
Copy link
Contributor Author

elharo commented Jan 24, 2020

Most usages of this should be in our own libraries; e.g. in java-storage. This client is rarely called directly by third party code, so I don't expect a lot of deprecation warnings in customer builds.

@elharo elharo merged commit 20ac5f6 into master Jan 26, 2020
@elharo elharo deleted the new branch January 26, 2020 18:40
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
* feat: add workforce support to ADC with pluggable auth

* feat: document workforce identity federation
clundin25 pushed a commit to clundin25/google-http-java-client that referenced this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants